[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: make-4.0 allows empty ARFLAGS to be passed to ar
From: |
Ken Moffat |
Subject: |
Re: make-4.0 allows empty ARFLAGS to be passed to ar |
Date: |
Mon, 21 Oct 2013 18:03:05 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Oct 21, 2013 at 05:36:24PM +0100, Ken Moffat wrote:
> On Mon, Oct 21, 2013 at 04:02:58PM +0000, Edward Welbourne wrote:
> > > It's the long one (subdir-dtc) where the problem exists.
> >
> > Obvious first step: configure quiet-command to actually show the
> > command, or remove this wrapping from the command, so that you can see
> > what the sub-make actually gets invoked with. We can guess, but it may
> > help to be entirely clear ! One thing to watch for: I'm not sure
> > whether all your quotes are actually going to survive the make-file
> > parsing and reach the shell ...
> >
> > I'm intrigued (but it's almost certainly off topic) that your calls to
> > quiet-command all end in a comma, $(call quiet-command,actual command,)
> > - what does quiet-command do with $2 ?
> >
> > Eddy.
>
> I haven't even figured out where quiet-command is located. I'm
> only an integration monkey, checking that everything in our "distro"
> (BLFS) will build with make-4.0. Will take a look.
>
> ĸen
1. The quiet-command is in rules.mak -
quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1))
And it's used in that file as well as generally. I'm not
sufficiently versed in this to try to change it - in particular I
don't grok the @$1 at the end. I do know that $V is normally unset
(it adds verbosity). Absolutely no idea about the comma, unless it
is syntactic sugar for a different make.
2. Unfortunately, rules.mak *is* adding -rR to the MAKEFLAGS -
# Don't use implicit rules or variables
# we have explicit rules for everything
MAKEFLAGS += -rR
Thanks for getting me to look at that.
I'll attach rules.mak. Is this a qemu bug which just happened to
work in make-3.82, or a make problem ?
ĸen
--
das eine Mal als Tragödie, dieses Mal als Farce
rules.mak
Description: Text document
- make-4.0 allows empty ARFLAGS to be passed to ar, Ken Moffat, 2013/10/20
- Re: make-4.0 allows empty ARFLAGS to be passed to ar, Paul Smith, 2013/10/21
- Re: make-4.0 allows empty ARFLAGS to be passed to ar, Ken Moffat, 2013/10/21
- Re: make-4.0 allows empty ARFLAGS to be passed to ar,
Ken Moffat <=
- Re: make-4.0 allows empty ARFLAGS to be passed to ar, Paul Smith, 2013/10/21
- Re: make-4.0 allows empty ARFLAGS to be passed to ar, Ken Moffat, 2013/10/21
- Re: make-4.0 allows empty ARFLAGS to be passed to ar, Paul Smith, 2013/10/21
- Re: make-4.0 allows empty ARFLAGS to be passed to ar, Ken Moffat, 2013/10/22
- Re: make-4.0 allows empty ARFLAGS to be passed to ar, Paul Smith, 2013/10/21