bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug #33138] .PARLLELSYNC enhancement with patch


From: Paul Smith
Subject: Re: [bug #33138] .PARLLELSYNC enhancement with patch
Date: Sat, 21 Sep 2013 18:26:43 -0400

On Thu, 2013-09-19 at 14:47 +0200, Frank Heckenbach wrote:
> Paul Smith wrote:
> 
> > *sigh*  If it weren't for the enter/leave messaging, the output-sync
> > feature would have been quite straightforward! :-/ :-).
> 
> I'm afraid so. But I think we're almost there now.

I've pushed what I hope are the last changes for this feature.  I'm
looking into other things now.  Please test this.

> > I didn't fix it this way.  Instead I used the existing MAKE_RESTART
> > environment variable to communicate from the current make to the
> > restarted make that the enter message was already printed (if it was) so
> > it wouldn't be printed again.  This ensures we don't get a stream of
> > enter/leave statements as we re-exec.
> > 
> > This works now (in my repo).
> 
> This seems even better. However, you still might have to call at
> least output_dump() before re-exec, especially if you sync the
> makefile parsing as discussed below.

I didn't need to before, because it was never possible to get out of
job.c functions with an outstanding sync.  In the new method, where we
are syncing the read of the makefiles, I needed to dump before starting
the remake section and also test this in die().




reply via email to

[Prev in Thread] Current Thread [Next in Thread]