[bug #16362] Regression: make -n causes $(shell) failure on Windows

[anonymous]

Follow-up Comment #2, bug #16362 (project make):

Submitted by J David Bryan <address@hidden>

Eli wrote, "Sounds like I should stop trying to maintain the Windows port, as
I cause more trouble than help."

Seems a bit of a harsh judgment.  In my view, the Windows port is in the best
shape ever.

To address the current problem, I see three alternative fixes:

1. Revert the patch so that batch files are always created, even with -n, and
then add code to delete the files explicitly for the -n case around line 1125
of job.c.

2. Add an extra calling parameter to "construct_command_argv" to indicate
whether the command will eventually be executed and so whether the batch file
should be created (flag would be always true for the invocation via the
"shell" function and conditional on -n otherwise).

3. Infer the type of call (shell function invocation vs. rule command
invocation) from the values of the parameters and condition batch file
creation on that and -n.

I'm not crazy about (3), and I'm not sure which of the other two, if either,
you'd find preferable.  Also, I believe I've seen mention that job.c is
undergoing renovations currently, so I'm loathe to select a repair method
without advice.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=16362>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/