bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

goto and macro usage


From: J. Grant
Subject: goto and macro usage
Date: Sun, 11 Jul 2004 00:09:25 +0100
User-agent: Mozilla/5.0 (X11; U; GNU/Linux i686; en; rv:1.0.0; hi)

Hello

I noticed use of goto's in the latest cvs make source code.  Are there
any plans to restructure so that goto/branches are not needed?  goto's
make the algorithms a little unclear IMO.

There are several common macro's in use. i.e. "record_waiting_files()",
"return_STRING_N_HASH_2".   Could these be migrated to functions (inline
or not), this would aid readability and /debugability/ of the source code.

variable.c has quite a few
variable.h has loads as well

I can make a patch to change these if this sort of change is agreeable.

Regards

JG





reply via email to

[Prev in Thread] Current Thread [Next in Thread]