Re: bug-lilypond Digest, Vol 173, Issue 17

[Christopher Heckman]

On Mon, Apr 17, 2017 at 9:00 AM,  <address@hidden> wrote:
>
> On Sun, Apr 16, 2017 at 9:00 AM, Martin Tarenskeen
> <address@hidden> wrote:
>
> On Sun, 16 Apr 2017, Christopher Heckman wrote:
>
>>> I like the idea and really appreciate your efforts, but I tried your patch
>>> and it doesn't seem to work (yet), at least not on my system. I can't
>
>> Hm. My Python might be a bit rusty, but the syntax doesn't differ from
>> the original code. However, you need to answer the "usual questions":
>
> Never mind.
> I found the "error". In your original message you wrote "replace the dump
> function with: (...your code... # end modified code)", so that's what I
> literally did.
>
> But the code you posted did not replace the *complete* function down to
> and including "return s". After your "# end modified code" there were
> still 3 lines of code in the original dump function that had to stay
> unchanged, not replaced.
>
>         global reference_note
>         reference_note_duration = self
>         return s

Okay, that would do it. Sorry about the mixup.

> Now it works. Where can I find your latest Git patch?

That's a good question. I submitted it, I think ... This is the first
time I've used git.

> I did some tests, and found occasions where the original version gives
> better results. I need to do more testing though.

That *is* strange. At worst, the output shouldn't change. Once again,
an example would be nice.

--- Christopher Heckman