Re: Page Spacer gets confused by next-space leading to unusable layout

[Joe Neeman]

On Sun, May 30, 2010 at 6:06 PM, Boris Shingarov <address@hidden> wrote:

> On 05/30/2010 03:52 AM, Joe Neeman wrote:
>
>> IIRC, tight-spacing just means to place lines as close together as
>> possible (which means a tight spring and a padding of zero).
>>
>
> That's what the code in page-layout-problem seems to be doing -- so I based
> my patch to page-breaking on simply trying to match the page-layout-problem.
> But what is the story behind tight-spacing in the first place?  Most
> importantly, what is the reasoning behind which lines are considered
> tight-spaced?


Basically, certain blocks of consecutive markup lines are marked as
having tight-spacing so that there aren't big gaps between lines of text.


>   The thing I find confusing, is on this line:
>
>
> padding = orig[i].title_ ? old.title_padding_ : old.padding_;
>
> how do I prove that it really should be orig[i].title_, as opposed to
> old.title_?


Padding is the padding below the current line. The padding below "old"
(taking into account whether "old" is a title) is already accounted in the
extent of the compressed line. The padding below the compressed line,
therefore, should depend on whether its bottom-most line is a title or not.

I can't easily push a patch from here, so perhaps someone else can apply it?

Cheers,
Joe