[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 659 in lilypond: alternative segno symbol
From: |
Mark Polesky |
Subject: |
Re: Issue 659 in lilypond: alternative segno symbol |
Date: |
Tue, 16 Mar 2010 22:17:48 -0700 (PDT) |
> Marc had proposed a patch, that doesn't seem to have been
> applied.
>
> http://codereview.appspot.com/181144
> http://lists.gnu.org/archive/html/lilypond-devel/2010-01/msg00162.html
>
> Can anyone have a look?
I can't comment on the C++ code, and I haven't studied the
output-lib.scm stuff, but...
1) the symbol has one too many squiggles, if we're using
this as our model:
http://code.google.com/p/lilypond/issues/detail?id=659
2) to separate paragraphs in the bar-line interface
docstring, you need to use "\n\n" --- one "\n" doesn't
generate a paragraph break. Also, don't start new
paragraphs with spaces. You can use the attached patch
to fix this.
3) again in the bar-line interface docstring, if @code{...}
isn't inside its own set of parentheses "(@code{...})",
@samp{...} is better. However, glancing around I see
that none of the other docstrings do this, so maybe
that should be addressed separately.
4) do you need to make a regression test?
5) you should also mention this in changes.tely
Other than that, this looks like some great work. Thanks
for contributing!
- Mark
ps. it's fun to see my auto-categorizing code in action
(in font-table.ly)
patch1.patch
Description: Text Data