[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/18] output.c: Fix potential NULL pointer dereferences
From: |
Tim Hentenaar |
Subject: |
[PATCH 10/18] output.c: Fix potential NULL pointer dereferences |
Date: |
Sat, 4 Jul 2015 13:43:24 +0200 |
Signed-off-by: Tim Hentenaar <address@hidden>
---
src/output.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/output.c b/src/output.c
index bc66c7b..9346495 100644
--- a/src/output.c
+++ b/src/output.c
@@ -545,17 +545,15 @@ static void set_next_buf_break (
}
xfree(buf_break);
+ if (!bb) goto ret;
/* Set buf_break to first break in the list */
-
buf_break = bb;
/* GDB_HOOK_buf_break */
-
buf_break->prev = NULL;
/* Find a better break of the existing breaks */
-
for (bb = buf_break; bb; bb = bb->next)
{
if (bb->col > settings.max_col)
@@ -580,6 +578,9 @@ static void set_next_buf_break (
}
}
}
+
+ret:
+ return;
}
/**
@@ -1363,7 +1364,7 @@ extern void close_output(
else
{
#ifdef PRESERVE_MTIME
- if (file_stats != NULL)
+ if (file_stats != NULL && filename)
{
struct utimbuf buf;
--
2.3.6
- [PATCH 00/18] Various fixes and improvements, Tim Hentenaar, 2015/07/04
- [PATCH 01/18] AM_CFLAGS: Add -ansi -pedantic and some warnings, Tim Hentenaar, 2015/07/04
- [PATCH 02/18] indent.h: Remove redundant extern declaration of else_or_endif, Tim Hentenaar, 2015/07/04
- [PATCH 03/18] globs: Fix malloc() wrapper functions, Tim Hentenaar, 2015/07/04
- [PATCH 04/18] s/free/xfree/g, Tim Hentenaar, 2015/07/04
- [PATCH 05/18] Move need_chars into handletoken.c, Tim Hentenaar, 2015/07/04
- [PATCH 06/18] args: Compiler warning fixes, Tim Hentenaar, 2015/07/04
- [PATCH 07/18] gperf*.c: Fix compiler warnings, Tim Hentenaar, 2015/07/04
- [PATCH 08/18] texinfo2man: Fix potential buffer overruns and NULL pointer dereferences, Tim Hentenaar, 2015/07/04
- [PATCH 09/18] output.c: Remove dead code, Tim Hentenaar, 2015/07/04
- [PATCH 10/18] output.c: Fix potential NULL pointer dereferences,
Tim Hentenaar <=
- [PATCH 11/18] output.c: Remove unused variable 'boolean_operator', Tim Hentenaar, 2015/07/04
- [PATCH 12/18] globs: Fix WARNING and ERROR macros to use char * instead of int *, Tim Hentenaar, 2015/07/04
- [PATCH 13/18] sys.h: Remove unused INLINE macro, Tim Hentenaar, 2015/07/04
- [PATCH 14/18] lexi.c: Remove dead code, Tim Hentenaar, 2015/07/04
- [PATCH 15/18] output: Don't shadow current_column(), Tim Hentenaar, 2015/07/04
- [PATCH 17/18] code_io.c: Fix file size test, Tim Hentenaar, 2015/07/04
- [PATCH 16/18] Makefile.am: Ensure indent builds with clang, Tim Hentenaar, 2015/07/04
- [PATCH 18/18] parse.h: Add prototype for debug_init(), Tim Hentenaar, 2015/07/04