bug-indent
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-indent] Re: #206785: Fixed: Bug#206785: indent segfaults on the att


From: Santiago Vila
Subject: [Bug-indent] Re: #206785: Fixed: Bug#206785: indent segfaults on the attached file
Date: Tue, 23 Sep 2003 16:19:55 +0200 (CEST)

On Tue, 23 Sep 2003, Erik de Castro Lopo wrote:

> Mine is a little more efficient. In my version, the function call is only made
> if the potential error condition occurs. In your version, the function call
> happens every time. On CPUs like i386, the function call overhead is
> significantly higher than the comparison anyway, so add the extra check in
> line is a worthwhile addition in a tight inner loop like this one.

Ok, I agree that the extra check might be more "efficient", but for
the Debian package I'm only interested in fixing the bug, so I've
applied the patch in its simple form, if only to respect the author's
style, since that's how it's done everywhere in indent.c.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]