[Bug-indent] No space before `*' in declarations

[Pavel Roskin]

Hello!

My previous patch was ignored:
http://mail.gnu.org/pipermail/bug-indent/2002-September/000493.html

Let me try one more time.  This patch is different because it fixes the
space not only in function definitions, but also in function declarations.
Also it only applies to "*".  Other binary operators are still followed by
space, although I don't think you can find them in declarations and
definitions.

=========================
--- src/indent.c
+++ src/indent.c
@@ -1039,7 +1039,11 @@ static exit_values_ty indent (
                     }
                 }

-                parser_state_tos->want_blank = true;
+                /* no space after * in declarations and definitions */
+
+                parser_state_tos->want_blank = !(token[0] == '*'
+                                                 && parser_state_tos->
+                                                    procname[0] != '\0');
                 break;

             case postop:                /* got a trailing ++ or -- */
=========================

Test file:
=========================
int f (foo_t *a, char *b);
int
f (foo_t *a, char *b)
{
    char *c;
    foo_t *d;
    return 1 * 2;
}
=========================

I also tested patched indent on large C files, and the difference from
indent 2.2.8 is only what I expect it to be.

There is an alternative solution that can be considered by those who know
the code better.  I believe that lexi() should return decl for "foo_t *a",
just like it would do for "struct foo_t *a"

If you look for "The following hack" in lexi.c, it doesn't check if the
parser is working with function arguments.  I don't feel save about
changing that huge condition without having the testsuite.

-- 
Regards,
Pavel Roskin