[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling sen
From: |
Joan Lledó |
Subject: |
Re: [PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send(). |
Date: |
Fri, 3 May 2019 13:34:33 +0200 |
Missatge de Samuel Thibault <samuel.thibault@gnu.org> del dia dj., 2
de maig 2019 a les 23:55:
> Put another way: instead, we have to go through flags which we see
> happen in the wild, and take appropriate measures (which may really be
> to just let lwip_sendmsg return EINVAL, or do the check ourselves if
> lwip_sendmsg does assertions instead of returning EINVAL).
What POSIX[1] says is that here we must return -1 and set errno to
EOPNOTSUPP, and that's what lwip does, so if this patch is not applied
it works fine. But there's a problem: you can't use lwip to resolve
names. In my tests, it seems glibc always add the flag MSG_NOSIGNAL to
the send() call when trying to resolve a name, which is an unsupported
flag. This is a big loss of functionality, what should we do?
--------------------
[1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/sendmsg.html
- [PATCH 1/2] lwip: Set output flags when calling recv(), (continued)
[PATCH 4/4] lwip: Call if_change_flags() inside a thread-safe context, Joan Lledó, 2019/05/02
[PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send()., Joan Lledó, 2019/05/02
- Re: [PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send()., Samuel Thibault, 2019/05/02
- Re: [PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send()., Samuel Thibault, 2019/05/02
- Re: [PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send().,
Joan Lledó <=
- Re: [PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send()., Samuel Thibault, 2019/05/03
- [PATCH 2/2] lwip: Fix bug: Clear MSG_NOSIGNAL flag when calling send()., Joan Lledó, 2019/05/04
- [PATCH 2/2] lwip: Fix bug: Clear MSG_NOSIGNAL flag when calling send()., Joan Lledó, 2019/05/04
- Re: [PATCH 2/2] lwip: Fix bug: Clear MSG_NOSIGNAL flag when calling send()., Samuel Thibault, 2019/05/04
[PATCH 3/4] lwip: Error handling when calling update_if(), Joan Lledó, 2019/05/02