[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] PCI Arbiter
From: |
Joan Lledó |
Subject: |
Re: [PATCH] PCI Arbiter |
Date: |
Thu, 26 Oct 2017 08:43:45 +0200 |
Hi!
2017-10-20 15:18 GMT+02:00 Justus Winter <teythoon@avior.uberspace.de>:
>
> I'd suggest pci-arbiter.
>
Done.
>> diff --git a/hurd/pci.defs b/hurd/pci.defs
>> new file mode 100644
>> index 00000000..d051bd69
>> --- /dev/null
>> +++ b/hurd/pci.defs
>> @@ -0,0 +1,50 @@
>> +/* Definitions for pci-specific calls
>> + Copyright (C) 2017 Free Software Foundation, Inc.
>> +
>> +This file is part of the GNU Hurd.
>> +
>> +The GNU Hurd is free software; you can redistribute it and/or modify
>> +it under the terms of the GNU General Public License as published by
>> +the Free Software Foundation; either version 2, or (at your option)
>> +any later version.
>> +
>> +The GNU Hurd is distributed in the hope that it will be useful,
>> +but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> +GNU General Public License for more details.
>> +
>> +You should have received a copy of the GNU General Public License
>> +along with the GNU Hurd; see the file COPYING. If not, write to
>> +the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. */
>> +
>> +subsystem pci 39000;
>> +
>> +#include <hurd/hurd_types.defs>
>> +
>> +#ifdef PCI_IMPORTS
>> +PCI_IMPORTS
>> +#endif
>> +
>> +INTR_INTERFACE
>
> Leftover here.
>
I cannot compile the server if I remove the `INTR_INTERFACE', The
mig-generated header doesn't mach my prototype. Is that what's left
over?
>> + /* Start the PCI system */
>> + err = pci_system_init ();
>> + if (err)
>> + error (1, err, "Error starting the PCI system");
>> +
>> + ports_manage_port_operations_one_thread (pci_bucket, pci_demuxer, 0);
>
> Maybe add a comment here that we rely on the one threaded nature of the
> server for synchronization.
>
OK
- PCI Arbiter, Joan Lledó, 2017/10/20
- [PATCH] PCI Arbiter, Joan Lledó, 2017/10/20
- Re: [PATCH] PCI Arbiter, Justus Winter, 2017/10/20
- Re: [PATCH] PCI Arbiter, Joan Lledó, 2017/10/21
- Re: [PATCH] PCI Arbiter, Justus Winter, 2017/10/22
- Re: [PATCH] PCI Arbiter, Samuel Thibault, 2017/10/22
- PCI Arbiter, Joan Lledó, 2017/10/24
- [PATCH] New module for the Hurd., Joan Lledó, 2017/10/24
- [PATCH] PCI Arbiter, Joan Lledó, 2017/10/24
- Re: [PATCH] PCI Arbiter,
Joan Lledó <=
- Re: [PATCH] PCI Arbiter, Justus Winter, 2017/10/26