Re: [PATCH] Simple testsuite for MIG.

[Justus Winter]

Quoting Flavio Cruz (2016-03-25 17:19:06)
> This includes a set of valid and invalid definition files that MIG will
> try to process. For valid definitions, GCC will compile the stubs to
> check if valid C code was generated.
> 
> * configure.ac: Add new test Makefiles.
> * Makefile.am: Add SUBDIRS.
> * tests/Makeconf.am: Automake definitions shared by all test subdirectories.
> * tests/test_lib.sh: Library of functions shared by all test drivers.
> * tests/good/run_good_test.sh: Script to run valid definition files.
> * tests/good/Makefile.am: New file.
> * tests/bad/run_bad_test.sh: Script to run invalid definition files.
> * tests/bad/Makefile.am: New file.
> * tests/generate-only/run_generate_only.sh: Script to run valid
> definition files that should be generated only.
> * tests/generate-only/Makefile.am: New file.
> * tests/includes/*.h: Test header files that are included by test stubs.
> * tests/good/*.defs: Valid definition files where generated stubs can
> be compiled.
> * tests/generate_only/*.defs: Valid definition files that can be
> generated but no compilation should be attempted.
> * tests/bad/*.defs: Definition files with some mistakes that should be
> recognized by MIG.
> ---
> 
> Hey,
> 
> On Wed, Mar 23, 2016 at 11:17:03AM +0100, Justus Winter wrote:
> > Quoting Flavio Cruz (2016-03-23 01:31:13)
> > > This includes a set of valid and invalid definition files that MIG will
> > > try to process. For valid definitions, GCC will compile the stubs to
> > > check if valid C code was generated.
> > 
> > Love the idea, but 1/ this breaks out of tree (vpath) builds, 2/ I
> > believe the traditional GNU make target for tests is 'check', 3/ the
> > test suite fails on Linux b/c of missing mach/mig_support.h, finally
> > 4/ automake has a test driver that might be useful.
> 
> Thanks for the comments! I think I have addressed all of them. Let me
> know if there's anything else missing.

Awesome!  Unfortunately:

============================================
   GNU MIG 1.6: tests/good/test-suite.log
   ============================================

# TOTAL: 7
# PASS:  6
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: import
============

Generating stubs for import...
Compiling stubs for import...
import-server.c:42:20: fatal error: server.h: No such file or directory
compilation terminated.
ERROR: Could not compile stubs for import
FAIL import.defs (exit status: 1)

Justus