Re: Rolling new releases

[Samuel Thibault]

Hello,

Thanks for the pending patches notices!

David Michael, le Tue 06 Oct 2015 17:49:00 -0400, a écrit :
> This one avoids problems with a symbol that is also provided by libpthread:
> https://anonscm.debian.org/viewvc/pkg-glibc/glibc-package/trunk/debian/patches/hurd-i386/tg-libc_getspecific.diff?view=co

What problem does it actually solve?  Apparently I didn't put enough
comments to remember what this is about.  AIUI, it should be working
fine already since this non-weak __libc_getspecific function calls
cthread_getspecific, which calls pthread_getspecific.

> I haven't checked if there's a new Debian patch for this, but there is
> an IS_IN macro from the future (build failure) since commit 8042775.
> Use IS_IN_rtld instead:
> http://git.savannah.gnu.org/cgit/hurd/glibc.git/tree/sysdeps/mach/hurd/cthreads.c?h=tschwinge/Roger_Whittaker#n23

Ah, right, this patch was for 2.22. In Debian we have different versions
of this change according to the version. Since Whittaker is still based
on 2.19, I have added the fix.

> Also, I believe either you or Samuel told me at some point that
> task_notify should be built in libmachuser instead of the proc server.

Yes.  I didn't realize the change was still not done in glibc.  I've now
pushed to upstream and our topgit.  I'll commit to Debian after a build
test (for the new symbols).

> and you can drop Debian's Hurd patch?

Yes.

> (Note to packagers that this will make glibc install a new file,
> <mach/task_notify.h>.)

That's not a problem.

Thanks,
Samuel