Re: RFC: [PATCH] trans/fakeroot.c

[Samuel Thibault]

Svante Signell, le Tue 12 May 2015 10:00:26 +0200, a écrit :
> On Tue, 2015-05-12 at 09:42 +0200, Samuel Thibault wrote:
> > Svante Signell, le Tue 12 May 2015 09:15:46 +0200, a écrit :
> > > The idea is to limit the openmodes according to the values defined in
> > > struct netnode and to change the test for overlapping sets.
> > 
> > In which case is this needed? What happens in that case and how the
> > patch fixes this?
> 
> I already supplied a test case. What's up?

Also, in the test case, you didn't explain what happens and what is
supposed to happen. Your patch seems to be dealing with modes, so
perhaps it's the modes which should be observed? But when running
fakeroot-hurd make the resulting file has mode 444, so it seems right.
Or perhaps it's the md5sum part which is bogus? But I do get the proper
md5sum.

When reporting a bug, *always* explain all of

- the steps to reproduce
- what you get
- what you expected to get

and when providing a patch, explain what I mentioned in my other mail.

Samuel