bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/4] trans/fakeroot: remove spurious semicolon


From: Justus Winter
Subject: [PATCH 1/4] trans/fakeroot: remove spurious semicolon
Date: Fri, 16 May 2014 18:56:24 +0200

A spurious semicolon caused a control flow bug in check_openmodes,
leading to a port leak.

* trans/fakeroot.c (check_openmodes): Remove spurious semicolon.
---
 trans/fakeroot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trans/fakeroot.c b/trans/fakeroot.c
index 987af24..0ea3cbf 100644
--- a/trans/fakeroot.c
+++ b/trans/fakeroot.c
@@ -222,7 +222,7 @@ check_openmodes (struct netnode *nn, int newmodes, file_t 
file)
          mach_port_deallocate (mach_task_self (), file);
          file = MACH_PORT_NULL;
        }
-      if (file == MACH_PORT_NULL);
+      if (file == MACH_PORT_NULL)
        {
          enum retry_type bad_retry;
          char bad_retryname[1024];     /* XXX */
-- 
2.0.0.rc0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]