[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] kern: make struct kmem_cache fit into two cache lines
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 5/5] kern: make struct kmem_cache fit into two cache lines |
Date: |
Fri, 03 Jan 2014 22:51:55 +0100 |
User-agent: |
Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) |
Justus Winter <4winter@informatik.uni-hamburg.de> skribis:
> Previously, the size of struct kmem_cache was 136 bytes, just eight
> bytes larger than 128 bytes, which is typically two cache lines on
> today's CPUs.
>
> By reducing the size of the name field which holds a human-readable
> description by eight bytes to 24 bytes, the struct kmem_cache can be
> made fit into two cache lines. This change should not affect the
> usefulness of this field. For reference, the length of the largest
> hard-coded name is 17.
I think it’d be worth keeping the explanation in a comment above the
macro definition.
Ludo’.
- [PATCH 1/5] vm: remove NS32000-specific padding from struct vm_page, Justus Winter, 2014/01/02
- [PATCH 3/5] vm: reduce the size of struct vm_page, Justus Winter, 2014/01/02
- [PATCH 4/5] kern: reduce the size of struct task, Justus Winter, 2014/01/02
- [PATCH 2/5] vm: merge the two bit fields in struct vm_page, Justus Winter, 2014/01/02
- [PATCH 5/5] kern: make struct kmem_cache fit into two cache lines, Justus Winter, 2014/01/02
- Re: [PATCH 1/5] vm: remove NS32000-specific padding from struct vm_page, Samuel Thibault, 2014/01/02