[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] device/net_io.c: add comments and initialize hash_entp
|
From: |
Justus Winter |
|
Subject: |
Re: [PATCH 1/2] device/net_io.c: add comments and initialize hash_entp |
|
Date: |
Mon, 02 Dec 2013 14:10:56 +0100 |
|
User-agent: |
alot/0.3.4 |
Quoting Marin Ramesa (2013-12-02 11:55:14)
> On 02.12.2013 10:37:08, Justus Winter wrote:
> > The other day you were fixing this kind of code, now you're
> > introducing it. Maybe there's a better way to silence this warning,
> > maybe some attribute.
>
> Maybe initialize to some kind of a template, like this:
No, that doesn't work. You are actually dereferencing a null pointer
here. Also, please inline your patches so they can be more easily
discussed.
See http://lwn.net/Articles/529954/ for what the Linux community did.
Justus