Re: [PATCH 2/5] ddb/db_sym.c: move assignment outside if

[Guillem Jover]

On Thu, 2013-11-21 at 13:11:05 +0100, Marin Ramesa wrote:
> diff --git a/ddb/db_sym.c b/ddb/db_sym.c
> index 0819e08..359ec7c 100644
> --- a/ddb/db_sym.c
> +++ b/ddb/db_sym.c
> @@ -276,7 +276,9 @@ db_name_is_ambiguous(sym_name)
>  
>       for (i = 0; i < db_nsymtab; i++) {
>               db_sym_t sp;
> -             if (sp = X_db_lookup(&db_symtabs[i], sym_name)) {
> +             boolean_t db_lookup;
> +             db_lookup = (int)(sp = X_db_lookup(&db_symtabs[i], sym_name));
> +             if (db_lookup) {
>                       if (found_once)
>                       {
>                               db_free_symbol(sp);

Regarding readability, this does not seem to me like a big improvement
(bar the squashed warning :). Why not assign sp on its own? And does
the db_sym_t type require a cast for the conditional?

Thanks,
Guillem