Re: [PATCH 3/7] ddb: create new header file db_mp.h

[Guillem Jover]

On Fri, 2013-11-22 at 18:30:36 +0100, Marin Ramesa wrote:
> diff --git a/ddb/db_mp.c b/ddb/db_mp.c
> index 831381f..81a567a 100644
> --- a/ddb/db_mp.c
> +++ b/ddb/db_mp.c
> @@ -56,11 +57,6 @@ int        db_slave[NCPUS] = { 0 };        /* nonzero if 
> cpu interrupted
>  
>  int  db_enter_debug = 0;
>  
> -void remote_db();            /* forward */
> -void lock_db();
> -void unlock_db();
> -
> -
>  /*
>   * Called when entering kernel debugger.
>   * Takes db lock. If we were called remotely (slave state) we just
> diff --git a/ddb/db_mp.h b/ddb/db_mp.h
> new file mode 100644
> index 0000000..a163d99
> --- /dev/null
> +++ b/ddb/db_mp.h
> @@ -0,0 +1,26 @@
> +/*
> + * Copyright (c) 2013 Free Software Foundation.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, write to the Free Software Foundation, Inc.,
> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + */
> +
> +#ifndef _DDB_DB_MP_H_
> +#define _DDB_DB_MP_H_
> +
> +void remote_db(void);
> +void lock_db(void);
> +void unlock_db(void);
> +
> +#endif /* _DDB_DB_MP_H_ */

Is it really correct to add that copyright and license header when
the stuff has just been moved? (The same for previous and subsequent
similar patches.)

Thanks,
Guillem