[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] utils: fix dead initialization
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 02/12] utils: fix dead initialization |
Date: |
Wed, 20 Nov 2013 23:48:12 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Wed 20 Nov 2013 14:37:55 +0100, a écrit :
> Found using the Clang Static Analyzer.
>
> * utils/frobauth.c (posix_parse_opt): Fix dead initialization.
> (no_ugids_parse_opt): Likewise.
Ack.
> ---
> utils/frobauth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/utils/frobauth.c b/utils/frobauth.c
> index ccb7c3b..44690d8 100644
> --- a/utils/frobauth.c
> +++ b/utils/frobauth.c
> @@ -209,7 +209,7 @@ ea_parse_opt (int key, char *arg, struct argp_state
> *state)
> static error_t
> posix_parse_opt (int key, char *arg, struct argp_state *state)
> {
> - struct frobauth_argp_state *fs = state->hook;
> + struct frobauth_argp_state *fs;
>
> switch (key)
> {
> @@ -233,7 +233,7 @@ posix_parse_opt (int key, char *arg, struct argp_state
> *state)
> static error_t
> no_ugids_parse_opt (int key, char *arg, struct argp_state *state)
> {
> - struct frobauth_argp_state *fs = state->hook;
> + struct frobauth_argp_state *fs;
>
> switch (key)
> {
> --
> 1.7.10.4
>
--
Samuel
La fonction memfrob() crypte les n premiers octets de la
zone de mémoire s en effectuant un OU-exclusif entre
chaque octet et le nombre 42.
(extrait de la page de man de memfrob -- Manuel du programmeur Linux)
- [PATCH 01/12] init: remove unused function run_for_real, Justus Winter, 2013/11/20
- [PATCH 02/12] utils: fix dead initialization, Justus Winter, 2013/11/20
- Re: [PATCH 02/12] utils: fix dead initialization,
Samuel Thibault <=
- [PATCH 05/12] fatfs: fix error handling in diskfs_lookup_hard, Justus Winter, 2013/11/20
- [PATCH 04/12] libnetfs: fix a dead store, Justus Winter, 2013/11/20
- [PATCH 03/12] libps: fix the length computation in fprint_frac_value, Justus Winter, 2013/11/20
- [PATCH 06/12] fatfs: fix error handling in diskfs_get_directs, Justus Winter, 2013/11/20
- [PATCH 07/12] ftpfs: fix error handling in refresh_dir, Justus Winter, 2013/11/20