bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 5/5] remove hyp_console_write() call


From: Marin Ramesa
Subject: [PATCH 5/5] remove hyp_console_write() call
Date: Wed, 11 Sep 2013 12:27:51 +0200

Please comment on this removal.

The check 'defined(MACH_HYP) && 0' never evaluates to TRUE, so
I'm guessing this was a way to comment out this code. I don't
see hyp_console_write() anywhere defined except in xen, so there
should be some checking for that too. Plus, the call itself look like 
it needs some rewrite.

I'm not sure about this removal, so if there is a reason to keep
this code, please ignore this patch.

* device/cons.c [defined(MACH_HYP) && 0]: Remove hyp_console_write() call.

---
 device/cons.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/device/cons.c b/device/cons.c
index 94d4ebf..92f1481 100644
--- a/device/cons.c
+++ b/device/cons.c
@@ -151,15 +151,6 @@ cnputc(c)
        kmsg_putchar (c);
 #endif
        
-#if defined(MACH_HYP) && 0
-       {
-               /* Also output on hypervisor's emergency console, for
-                * debugging */
-               unsigned char d = c;
-               hyp_console_write(&d, 1);
-       }
-#endif /* MACH_HYP */
-       
        if (cn_tab) {
                (*cn_tab->cn_putc)(cn_tab->cn_dev, c);
                if (c == '\n')
-- 
1.8.1.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]