[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] ddb: cleanup db_command.c
From: |
Marin Ramesa |
Subject: |
Re: [PATCH 4/4] ddb: cleanup db_command.c |
Date: |
Thu, 11 Jul 2013 15:49:56 +0200 |
On 10.07.2013 14:14:29, Marin Ramesa wrote:
> Use new .h files in cleanup of db_command.c.
I noticed that these four patches are very similar to what was done in
XNU. Now, I don't know if they should be applied to GNU Mach, I'm not
a legal expert, so I don't know if this patches are a copyright
violation of some kind. Or they are just too trivial for that.
I mean, the function prototypes and include directives do not match
exactly, since it's a different version of Mach, but the layout of the
new .h files is the same. It's logical to organize debug print
functions into *-print.h files and to write .h files in such a way.
Everyone would do it, since writing a prototype is just modifying from
an existing function definition and it's nothing original.
I don't know. If these patches are a copyright violation I wouldn't
apply them to a publicly available source repository.