[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported
From: |
Pino Toscano |
Subject: |
Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported |
Date: |
Mon, 29 Oct 2012 17:17:42 +0100 |
User-agent: |
KMail/1.13.7 (Linux/3.2.0-3-amd64; KDE/4.8.4; x86_64; ; ) |
Alle giovedì 25 ottobre 2012, Roland McGrath ha scritto:
> We don't generally handle MIG_BAD_ID. That error indicates a server
> not implementing the protocol for which it's being used, which is a
> server bug. If anything, we'd translate that to EGRATUITOUS in the
> general case, and perhaps to EOPNOTSUPP in particular cases where
> it's not an ironclad part of the interface contract that it
> implement the particular protocol. So I think we should separate
> the MIG_BAD_ID case and treat it more generally, if at all.
OK, it seems it could actually be a bug in pflocal, sorry for the bad
investigation of thi.s
> Since it's the norm for servers to return EOPNOTSUPP for
> miscellaneous RPCs they aren't implementing, translating that to
> EINVAL for fsync/fdatasync is reasonable. It should have a comment
> saying that POSIX.1 specifies EINVAL for a file descriptor on which
> sync is not supported.
Attached an updated patch to handle only EOPNOTSUPP, with comment added.
Thanks,
--
Pino Toscano
hurd_fsync.diff
Description: Text Data
signature.asc
Description: This is a digitally signed message part.
- Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported, Pino Toscano, 2012/10/24
- Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported, Roland McGrath, 2012/10/25
- Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported, Samuel Thibault, 2012/10/25
- Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported, Svante Signell, 2012/10/26
- Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported, Samuel Thibault, 2012/10/26
- Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported, Pino Toscano, 2012/10/26
- Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported, Samuel Thibault, 2012/10/26
- Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported, Richard Braun, 2012/10/26
- Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported, Samuel Thibault, 2012/10/26
- Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported, Roland McGrath, 2012/10/26
Re: [PATCH.HURD] fix fdatasync/fsync if file_sync is not supported,
Pino Toscano <=