Fwd: [httpfs][PATCH] Fix compilation and bugs.

[Cyril Roelandt]

Forwarding this to this list, since hurdextras-hackers seems a bit deserted.


-------- Original Message --------
Subject: [httpfs][PATCH] Fix compilation and bugs.
Date: Sat, 14 Jul 2012 03:41:35 +0200
From: Cyril Roelandt <tipecaml@gmail.com>
To: hurdextras-hackers@nongnu.org

Hi !

I wanted to try httpfs, but the code from the CVS repository failed to
compile on my Debian GNU/Hurd box. So, here are a few patches.

- The first patch fixes the compilation of httpfs. This is a mix of an
old patch
(https://savannah.nongnu.org/patch/?func=detailitem&item_id=4839) and of
some really simple fixes.

- The second patch adds -lpthread to the linker options. Basically,
there is a bug that prevents libpthread from being dlopened properly,
and the standard workaround is to link the application itself with
libpthread.

- The third patch just reindents http.c :)

- The fourth patch fixes a bug that caused some calls to free() in
fill_dirnode() to fail. It is caused by an error in the sizes passed to
malloc(). I'm really not sure of what I did for the code located in the
"if (go->f_type == HTTP_URL)" statement (the original code looked a bit
obfuscated to me) but I'm pretty sure I'm doing the right thing in the
rest of the patch. Anyway, this made httpfs work for me.


I hope it helps.

Cyril.

01.fix-compilation.patch
Description: Text Data

02.fix-linker.patch
Description: Text Data

03.indent-http.c
Description: Text Data

04.Fix-allocation-sizes.patch
Description: Text Data