[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH,HURD] hurd: compliance fixes for ptsname_r
From: |
Pino Toscano |
Subject: |
Re: [PATCH,HURD] hurd: compliance fixes for ptsname_r |
Date: |
Sat, 28 Apr 2012 14:28:01 +0200 |
User-agent: |
KMail/1.13.7 (Linux/3.2.0-2-amd64; KDE/4.7.4; x86_64; ; ) |
Alle sabato 28 aprile 2012, Roland McGrath ha scritto:
> Compliance with what? Is there a standard that specifies ptsname_r?
It is a Linux-specific function is implemented by GNU libc and other
systems.
> We don't use implicit boolean coercions, we use (buf != NULL).
Noted.
> But unless there is a standard requiring that you diagnose a
> null pointer argument somehow, then it's actually better that
> it just crash.
Ok, I see that its `buf' argument is marked nonnull. I added that check
because I saw the gnulib test for it explicitly checking that
ptsname_r(fd, NULL, 0) would be properly failing with EINVAL (and the
man page even explicitly mention that return value, unlike with
basically most of the other functions). Should gnulib do that check only
on Linux, then?
Attached the updated patch, also with the hits of the other reviews.
Thanks,
--
Pino Toscano
hurd_ptsname.diff
Description: Text Data
signature.asc
Description: This is a digitally signed message part.