bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/17] Match signedness of char pointer comparisons and assig


From: Samuel Thibault
Subject: Re: [PATCH 13/17] Match signedness of char pointer comparisons and assignments
Date: Sat, 27 Aug 2011 01:02:18 +0200
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Guillem Jover, le Thu 25 Aug 2011 15:22:36 +0200, a écrit :
> * linux/dev/drivers/block/genhd.c (msdos_partition): Cast `data' assignment
> to `unsigned char *'.
> * linux/src/drivers/block/ide-cd.c (cdrom_queue_request_sense): Cast
> `buffer' assignment to `unsigned char *'.
> (cdrom_transfer_packet_command): Change `cmd_buf' argument type to
> `unsigned char *'.
> (cdrom_read_capacity): Cast `pc.buffer' assignments to `unsigned char *'.
> Use temporary `model' and `fw_rev' `const char *' variables to compare
> against literal strings and characters.
> * linux/src/drivers/block/ide.c (execute_drive_cmd): Cast `args'
> assignment to `byte *'.
> (ide_open): Cast `rq.buffer' assignment to `char *'.
> (ide_release): Likewise.
> (ide_ioctl): Likewise.
> (do_identify): Cast variables being compared against literal string to
> `char *'.
> (probe_for_drive): Likewise.
> * linux/src/drivers/block/ide.h (struct packet_command): Change `buffer'
> type to `unsigned char *'.

Applied, thanks.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]