Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO

bug-hurd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)

From:	Jérémie Koenig
Subject:	Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)
Date:	Thu, 15 Jul 2010 16:36:58 +0200

On Thu, Jul 15, 2010 at 4:07 PM, Emilio Pozuelo Monfort
<pochu27@gmail.com> wrote:
>  error_t
>  S_socket_getopt (struct sock_user *user,
>                 int level, int opt,
>                 char **value, size_t *value_len)
>  {
> +  if (level == SOL_SOCKET)
> +    {
> +      if (opt == SO_TYPE)
> +       {

Maybe switch statements would be more future-friendly?
(just my 2 nitpicking cents)

-- 
Jérémie Koenig <jk@jk.fr.eu.org>
http://jk.fr.eu.org/

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/15
- Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Jérémie Koenig <=
  - Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/15
    - Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/15
    - Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/15
    - Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Carl Fredrik Hammar, 2010/07/15
    - Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/17
    - Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Samuel Thibault, 2010/07/17
    - Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Carl Fredrik Hammar, 2010/07/17
    - Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Carl Fredrik Hammar, 2010/07/17
    - Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Emilio Pozuelo Monfort, 2010/07/17
    - Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...), Ludovic Courtès, 2010/07/17

Prev by Date: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)
Next by Date: Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)
Previous by thread: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)
Next by thread: Re: [PATCH] Implement getsockopt (fd, SOL_SOCKET, SO_TYPE, ...)
Index(es):
- Date
- Thread