[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: exec server and /dev/fd/N
|
From: |
Emilio Pozuelo Monfort |
|
Subject: |
Re: exec server and /dev/fd/N |
|
Date: |
Wed, 26 May 2010 01:39:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100515 Icedove/3.0.4 |
On 25/05/10 21:10, Carl Fredrik Hammar wrote:
>> @@ -278,7 +280,9 @@ check_hashbang (struct execdata *e,
>> else
>> name = argv;
>>
>> - if (strchr (name, '/') != NULL)
>> + if (filename)
>> + error = lookup (name = filename, 0, &name_file);
>> + else if (strchr (name, '/') != NULL)
>> error = lookup (name, 0, &name_file);
>> else if ((error = hurd_catch_signal
>> (sigmask (SIGBUS) | sigmask (SIGSEGV),
>
> Should check for "" instead of null.
Shouldn't I check both to avoid somebody using the RPC directly and sending NULL
in filename to crash the exec server and cause a DoS? (-:
Emilio