Re: [PATCH] tmpfs: add padding to tmpfs_dirent structure

[Carl Fredrik Hammar]

Hi,

On Tue, May 18, 2010 at 04:19:34PM +0200, Sergio Lopez wrote:
> This patch adds some padding to tmpfs_dirent structure as it's
> suggested in the wiki
> (http://www.gnu.org/software/hurd/hurd/translator/tmpfs.html).
> 
>
> diff -du hurd-deb.orig/tmpfs/tmpfs.h hurd/tmpfs/tmpfs.h
> --- hurd-deb.orig/tmpfs/tmpfs.h       2010-05-06 11:37:31.000000000 +0200
> +++ hurd/tmpfs/tmpfs.h        2010-05-18 16:13:53.000000000 +0200
> @@ -64,6 +64,7 @@
>  {
>    struct tmpfs_dirent *next;
>    struct disknode *dn;
> +  char padding[3]; /* align with dirent structure */
>    uint8_t namelen;
>    char name[0];
>  };

This patch is actually on the wiki (sans the comment) along with another
one that fixes symlinks.  Perhaps you could adopt that patch as well
and try to get it checked in since you're already working on tmpfs.

Regards,
  Fredrik