Re: [PATCH 1/3] Add the ``--mount'' command line option

[Sergiu Ivanov]

Hello,

On Fri, Jul 10, 2009 at 03:23:29AM +0200, olafBuddenhagen@gmx.net wrote:
> On Sun, Jul 05, 2009 at 07:17:33PM +0300, Sergiu Ivanov wrote:
> > On Fri, Jul 03, 2009 at 06:52:37AM +0200, olafBuddenhagen@gmx.net
> > wrote:
> 
> > > This surely needs some special handling in netfs_append_args() as
> > > well?...
> > 
> > Yes, it does, of course.  I didn't implement it right here because I
> > misunderstood your suggestion to implement the union mount
> > functionality *before* any command line handling.
> > 
> > However, from my experience with using git, I'd say it shouldn't be
> > very hard to insert a patch which adapts the behaviour of
> > netfs_append_args.
> 
> Well, it should go into the same patch: without it, you get a translator
> that doesn't properly handle fsysopts -- and as I said before, generally
> we should try to have a fully working program at any point in a patch
> series.

I have added the handling of ``--mount'' option.

> > > BTW, what happens if the user specifies multiple --mount options?
> > > From the looks of it, it won't blow up completely, but won't really
> > > handle it in a useful way either?
> [...]
> > Should I just add this check or should error out some message, what do
> > you think?
> 
> I'm quite undecided myself :-(
> 
> Just pick what seems most useful to you I'd say -- we can still change
> it later...

I think that printing an error message is better because in this case
the user knows exactly what is happening.  I added this change to the
patch.
 
> > > Another case I wonder about is mixing of --mount and "ordinary"
> > > arguments -- is it actually possible to do that?
> [...]
> It seems to me that mixing won't be possible in proxy mode though -- but
> that's for later :-)

Why not? :-) Indeed, in proxy mode it is impossible to invoke
fsys_set_options on unionmount itself, but you still can specify
additional filesystems when setting up the unionfs translator.  It
will become impossible to add filesystems only if we decide to modify
the command line handling of unionfs greatly.

Regards,
scolobb