Re: [PATCH 3/3] Add the code for adding the mountee to the merged filesystems

[Sergiu Ivanov]

Hello,

On Fri, Jul 03, 2009 at 07:07:59AM +0200, olafBuddenhagen@gmx.net wrote:
> On Thu, Jun 11, 2009 at 09:25:10PM +0300, Sergiu Ivanov wrote:
> 
> > +  ulfs_register ("\0", 0, 0);
> 
> "\0" is wrong -- it will generate a string consisting of *two* \0
> characters. Just use an empty string.

Ah, yeah... I've forgotten this fact :-(
 
> > +  ulfs_check ();
> > +  node_init_root (netfs_root_node);
> 
> Why is this needed here and not in the original code?...

ulfs_check is used to update the list of ports to the underlying
filesystems maintained by unionfs, while node_init_root is used to
store a (similar) list of ports in the root node.

unionfs invokes both of these functions only in _root_update_thread
and does this with the point of doing a global synchronization,
i.e. making sure the merged directories still exist and dropping dead
items.

I call these functions explicitly because I want to force the update
of the list of filesystems and the root node.  I guess I could use
root_update_schedule instead, or just move the invocation of
setup_unionmount before the first nested loop in _root_update_thread.
 
> (Regarding ulfs_check(), I already asked in the previous feedback IIRC.)

Yeah, I remember.  I planned to answer to your question by writing a
comment before these lines in the ``--mount'' series of patches, but
forgot to do that :-(

Regards,
scolobb