Re: Kernel crash on device_map DEVICE_NULL

[John Tobey]

On Fri, Nov 23, 2001 at 05:28:14PM -0500, Roland McGrath wrote:
> As Marcus explained, this is just historical cruft.  For your project, I
> think you would be better off starting with oskit-mach.  I have cleaned up
> and removed a lot of random cruft there.  Also, the oskit module interfaces
> are designed for exactly the kind of different-hosting concept that you are
> working on.

Okay, while I look for oskit-mach (is it to the point yet where one
might link to it from the GNU Mach pages?), please consider the
following (untested!) patch for gnumach in light of
http://mail.gnu.org/pipermail/bug-hurd/1999-December/000862.html
"Non-root user can read raw disk!":

2001-11-24  John Tobey  <jtobey@john-edwin-tobey.org>

        * device/ds_routines.c (device_open): Require master device port
        for i386.


Index: device/ds_routines.c
===================================================================
RCS file: /cvsroot/hurd/gnumach/device/ds_routines.c,v
retrieving revision 1.6
diff -u -r1.6 ds_routines.c
--- device/ds_routines.c        2001/10/07 22:36:02     1.6
+++ device/ds_routines.c        2001/11/24 14:54:58
@@ -112,7 +112,6 @@
        char                    namebuf[64];
        ipc_port_t              notify;
 
-#ifndef i386
        /*
         * Open must be called on the master device port.
         */
@@ -128,6 +127,7 @@
            return (MIG_NO_REPLY);      /* no sense in doing anything */
        }
 
+#ifndef i386
 #if    NORMA_DEVICE
        /*
         * Map global device name to <node> + local device name.
END OF PATCH.