bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: oskit-mach: vm_map_copyout crash


From: Daniel Wagner
Subject: Re: oskit-mach: vm_map_copyout crash
Date: Tue, 6 Nov 2001 23:07:15 +0100
User-agent: Mutt/1.2.5i

On Mon, 05 Nov 2001, Roland McGrath wrote:

> You said "fixing kmalloc was easy", but I didn't see you post any change to
> the oskit code.  I'm not at all sure that kmalloc should change.

Ok, here is what I fixed. mflags is passed to oskit_skufio_mem_alloc but
it is not passed to kamlloc. If it is not completely wrong I post it to
oskit-users.

wagi


Index: skbuff_mem.c
===================================================================
RCS file: /cvs/oskit/linux/dev/skbuff_mem.c,v
retrieving revision 1.1.1.2
diff -c -p -u -r1.1.1.2 skbuff_mem.c
diff: conflicting specifications of output style
--- skbuff_mem.c        2001/02/20 17:58:50     1.1.1.2
+++ skbuff_mem.c        2001/11/06 22:02:00
@@ -109,7 +109,7 @@ oskit_skbufio_mem_alloc(oskit_size_t siz
                SKB_CACHE_STAT(bad_size++);
        }
 
-       skb = kmalloc(SKB_HDRSIZE + size, GFP_ATOMIC);
+       skb = kmalloc(SKB_HDRSIZE + size, GFP_ATOMIC | mflags);
 
  gotone:
        linux_restore_flags(flags);




-- 
Daniel Wagner                              "use quit to exit"
email: wagi@gmx.ch

GnuPG: 1024D/DCDE890A (public key available on any keyserver)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]