bug-gzip
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] tests: use more portable fd redirection in TESTS_ENVIRONMENT


From: Stefano Lattarini
Subject: [PATCH] tests: use more portable fd redirection in TESTS_ENVIRONMENT
Date: Wed, 12 Oct 2011 11:25:52 +0200
User-agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )

You might also want to apply the attached follow-up, with prevents
an unportable usage of fd redirections in TESTS_ENVIRONMENT.

Regards,
  Stefano
From e0512ba0b9e0f91f9f4af0afb9935247b4b5eb91 Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Wed, 12 Oct 2011 11:14:15 +0200
Subject: [PATCH] tests: use more portable fd redirection in TESTS_ENVIRONMENT

* tests/Makefile.am (TESTS_ENVIRONMENT): Redirection with `exec 9>&2'
is not portable to various Korn shells, and to (at least) HP-UX 11
/bin/sh.  Use a more portable idiom.
See <http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/22488> for
lots of discussion.
---
 tests/Makefile.am |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 0bf072f..0def096 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -52,7 +52,6 @@ built_programs = \
 TESTS_ENVIRONMENT =                            \
   tmp__=$$TMPDIR; test -d "$$tmp__" || tmp__=.;        \
   TMPDIR=$$tmp__; export TMPDIR;               \
-  exec 9>&2;                                   \
   export                                       \
   LC_ALL=C                                     \
   VERSION=$(VERSION)                           \
@@ -70,6 +69,6 @@ TESTS_ENVIRONMENT =                           \
   PERL='$(PERL)'                               \
   SHELL='$(SHELL)'                             \
   PATH='$(abs_top_builddir)$(PATH_SEPARATOR)'"$$PATH" \
-  ;
+  ; 9>&2
 
 VERBOSE = yes
-- 
1.7.2.3


reply via email to

[Prev in Thread] Current Thread [Next in Thread]