bug-gzip
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug in gzip 1.4?


From: Jim Meyering
Subject: Re: Bug in gzip 1.4?
Date: Thu, 02 Dec 2010 11:52:35 +0100

Paul Eggert wrote:
...
> Subject: [PATCH] * NEWS: The "gzip -f foo.gz" change occurred in 1.3.13, not 
> 1.3.12
> diff --git a/NEWS b/NEWS
> +** 'gzip -f foo.gz' now creates a file foo.gz.gz instead of complaining.
> +
...
> -* 'gzip -f foo.gz' now creates a file foo.gz.gz instead of complaining.
> -

Thanks for fixing that.
Any time you change NEWS items not for the upcoming release, you should
run "make update-NEWS-hash" to update the checksum in cfg.mk.
This may seem like a pointless annoyance, but when you merge an
old change that pulls a NEWS item into the prior release's section,
you'll appreciate it.  Humans can overlook the error, since it's hard
to spot via a context diff, but this will catch it.

Otherwise, this "make syntax-check" test will fail:

    maint.mk: you have modified old NEWS
    make: *** [sc_immutable_NEWS] Error 1
    make: *** Waiting for unfinished jobs....

I've just pushed this:

>From 37a1000f5dda4f42aa1d626752a2125e0a4187d5 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 2 Dec 2010 11:44:41 +0100
Subject: [PATCH] maint: avoid "make syntax-check" failure due to old-NEWS 
modification

* cfg.mk (old_NEWS_hash): Update, to reflect recent NEWS correction.
---
 cfg.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cfg.mk b/cfg.mk
index 879637b..b1f18c6 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -38,7 +38,7 @@ bootstrap-tools = autoconf,automake,gnulib
 # Now that we have better tests, make this the default.
 export VERBOSE = yes

-old_NEWS_hash = e35901d8427a032d2b88a3195ed24a8f
+old_NEWS_hash = 4e76bc5d3e489bb63342e85762172502

 sc_obs_header_regex = \
   \<(STDC_HEADERS|HAVE_(LIMITS|STRING|UNISTD|STDLIB)_H)\>
--
1.7.3.2.846.gf4b062



reply via email to

[Prev in Thread] Current Thread [Next in Thread]