Re: Bug#404114: gzip: [zdiff] Infine loop in "while : do .. case $1 esac done"

[Jari Aalto]

Paul Eggert <address@hidden> writes:

> Thanks for reporting that.  zdiff really is a can of worms.
> Can you please try this patch?  I installed it into the main CVS for gzip.
>
> 2006-12-23  Paul Eggert  <address@hidden>
>
>       * zdiff.in: Fix typo that broke most usages.  Problem reported by
>       Jari Aalto in <http://bugs.debian.org/404114>.  While we're at it,
>       fix a bunch of other problems.  Handle "-" better.  Send
>       diagnostics to stderr, not stdout.  Use expr rather than echo |
>       sed, to handle special characters better.  Report a diagnostic in
>       the 1-arg case, if the argument doesn't end in .gz or the like,
>       rather than having incomprehensible behavior.  Do not require that
>       the inputs be regular files.  Avoid creating a temporary entirely,
>       if /dev/fd works.  If not, then resist denial-of-service attacks
>       better, by using mktemp.
>       * Makefile.am (gzip.doc.gz): New rule.
>       (check-local): Depend on it, and test zdiff for Debian bug 404114.

Confirmed. This fixes the bug; compiled from CVS.

Jari