[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33896: libblockdev inputs are not used correctly
From: |
Ludovic Courtès |
Subject: |
bug#33896: libblockdev inputs are not used correctly |
Date: |
Sat, 05 Jan 2019 18:55:52 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello,
Efraim Flashner <address@hidden> skribis:
> On Fri, Dec 28, 2018 at 02:32:55PM +0100, Danny Milosavljevic wrote:
>> Currently, libblockdev has inputs which aren't used.
>>
>> These SHOULD be used, but the source files are not patched
>> so the executables in the inputs are not found or used.
>>
>> Example:
>>
>> * libblockdev depends on dosfstools because src/plugins/fs/vfat.c would use
>> "mkfs.vfat" etc, but src/plugins/fs/vfat.c is not patched to actually refer
>> to the inputs.
>>
>> This problem is valid for everything in src/plugins/fs .
>>
>> Do we proceed to patch it to use the inputs or do we move dosfstools etc
>> to propagated-inputs ?
>>
>> I'd suggest the former.
>
> Similar to the enlightenment package getting more 'substitute*'s to
> improve functionality, I agree that patching libblockdev to actually
> find all the inputs/executables is preferable.
I agree; using ‘substitute*’ is more appropriate than propagation here.
Thanks,
Ludo’.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#33896: libblockdev inputs are not used correctly,
Ludovic Courtès <=