bug#31974: If a phase returns #f, a warning is issued, but the build continues

[Mark H Weaver]

Mark H Weaver <address@hidden> writes:

> I just noticed that I made a mistake in commit
> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in
> (guix build gnu-build-system) to issue a warning if a phase returns a
> value other than #t.
>
> The result is that if a phase returns a value other than #t, a warning
> is issued, but the build nonetheless continues to the next phase, and
> the build could ultimately "succeed" even some phases returned #f.
>
> In other words, the return values of phases are effectively ignored,
> except for the warning, so the only way to cause a build with phases to
> fail is to raise an exception.

This should be fixed by commit 82230603ce06de7aa3e4aef2fa093a6dbf0ef8df
in core-updates.

      Mark