Re: [bug-gtypist] ideas, implementations, patches.

[clutton]

On Sun, 2016-05-15 at 10:00 +0200, Felix Natter wrote:
> clutton <address@hidden> writes:


Could you guys please check this patch out?

1) malloc->stdlib obvious.
2) the change I was talking about, include <curses.h> instead of
<ncursesw/ncursesw.h>, if you still don't believe that this is the
thing to do check out if your curses.h has function prototypes
like add_wch, etc.
2) AM_ICONV doesn't work for me somehow, does it add -liconv for you?
It looks like everything is ok

checking for iconv... yes
checking for working iconv... yes
checking how to link with libiconv... /usr/local/lib/libiconv.so -Wl,-
rpath -Wl,/usr/local/lib
checking for iconv declaration... 
         extern size_t iconv (iconv_t cd, char * *inbuf, size_t
*inbytesleft, char * *outbuf, size_t *outbytesleft);
checking whether NLS is requested... yes
checking for msgfmt... /usr/local/bin/msgfmt
checking for gmsgfmt... /usr/local/bin/msgfmt
checking for xgettext... /usr/local/bin/xgettext
checking for msgmerge... /usr/local/bin/msgmerge
checking for CFPreferencesCopyAppValue... no
checking for CFLocaleCopyCurrent... no
checking for GNU gettext in libc... no
checking for iconv... (cached) yes
checking for working iconv... (cached) yes
checking how to link with libiconv... /usr/local/lib/libiconv.so -Wl,-
rpath -Wl,/usr/local/lib

    But then I have a linking error:

gcc  -g -O2   -o gtypist gtypist.o cursmenu.o  script.o error.o
getopt.o  getopt1.o infoview.o speedbox.o  banner.o cmdline.o utf8.o
/usr/local/lib/libintl.so -Wl,-rpath -Wl,/usr/local/lib -lncursesw
utf8.o: In function `convertUTF8ToCurrentEncoding':
/home/develop/c/gtypist/src/utf8.c:65: undefined reference to
`libiconv_open'
/home/develop/c/gtypist/src/utf8.c:76: undefined reference to
`libiconv'
/home/develop/c/gtypist/src/utf8.c:95: undefined reference to
`libiconv_close'
collect2: error: ld returned 1 exit status


Any ideas about this? One way must be removed, either AM_ICONV or mine,
which is:
AC_CHECK_LIB(iconv, iconv_open, [], [AC_MSG_ERROR(
    [iconv library is missing: See INSTALL file for further
information])])

patch0.diff
Description: Text Data

signature.asc
Description: This is a digitally signed message part