Re: [RFC] netboot changes

[Thierry Laronde]

On Mon, Jan 15, 2001 at 12:41:13AM +0700, Eugene A. Doudine wrote:
> 
> Hello, Thierry

Hello Eugene,

> 
> I recently had the same problems with GRUB netbooting, and already
> done just what you suggested:
>  added new field to pci_device struct - pointer to correct probe 
>  routine:
> struct pci_device {
>         unsigned short  vendor, dev_id;
>         const char      *name;
>         unsigned int    membase;
>         unsigned short  ioaddr;
>         unsigned short  devfn;
>         struct nic      *(*eth_probe)(struct nic *, unsigned short *,
>                                       struct pci_device *);
> };
> and added code to call the correct probe function before trying
> all the drivers. 

Great !

>I was in doubt whom I shoud bug with it: Okuji or 
> Etherboot maintainers. 


As far as I understand, the "multi-devices try" belong to GRUB,
Etherboot needs only to probe one. So I think your patch belongs indeed
to GRUB (but I might be wrong), but it is perhaps worth the effort to
investigate if the GRUB patched version can be made "inoffensive" for
Etherboot just in order that any upstream modification of Etherboot 
code embeds natively GRUB modifications.

>I attached my patch to this message so 
> we avoid unneeded duplication of efforts.  This is my current and 
> working version. 

Thanks :)
> 
> By the way I looked into recent Etherboot distribution 
> and found that version in grub is quite dated 5 or 8 month old, 
> Etherboot has some new drivers, pci_device struct is also changed. 
> However this problem with non-optimal probing sequence of pci devices 
> still exists in Etherboot too.

I will try to give a look at the last version too.

Thierry LARONDE <address@hidden>
10, rue du Bel Air, 74000 ANNECY - FRANCE/ Tel : 33.(0)4.50.67.46.61
/home du SDF (Site Debian Francophone) : http://www.polynum.com/sdf/