[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #64485] [libgroff] fontfile.cpp: null destination pointer [-Wformat
From: |
G. Branden Robinson |
Subject: |
[bug #64485] [libgroff] fontfile.cpp: null destination pointer [-Wformat-overflow=] |
Date: |
Wed, 2 Aug 2023 12:50:25 -0400 (EDT) |
Update of bug #64485 (project groff):
Status: In Progress => Fixed
Open/Closed: Open => Closed
Planned Release: None => 1.24.0
_______________________________________________________
Follow-up Comment #3:
commit c64c8d4eea00b9b449e2836d3469b57a772f2e71
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date: Sat Jul 29 06:02:36 2023 -0500
[libgroff]: Fix Savannah #64485 (validation).
* src/libs/libgroff/fontfile.cpp (font::open_file): Do more parameter
validation. Don't construct a file name for opening from components
that are null pointers. Also `assert()` this since it should be an
invariant. Migrate from `sprintf()` to `snprintf()`; we have the size
of the destination buffer handy. Update `#include`s.
Fixes <https://savannah.gnu.org/bugs/?64485>. Thanks to Bjarni Ingi
Gislason for the report.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?64485>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug #64485] [libgroff] fontfile.cpp: null destination pointer [-Wformat-overflow=],
G. Branden Robinson <=