[bug #55044] [PATCH] contrib/hdtbl/hdmisc.tmac-u: register 'M#' must be reset to 0 at the start of a new page

[Ingo Schwarze]

Follow-up Comment #3, bug #55044 (project groff):

Obviously, changing anything below examples/ cannot fix an issue in the macro
files themselves, so the obviously useless patch in comment #2 was not even
worth testing.  Posting patches that you already know to be wrong is not a
good idea.

> I was ONLY assessing the use of the undefined variable "M#",
> nothing else as the original subject tells.

That is a serious problem right there.  Don't do that, ever.

Auditing compiler warnings is a TOOL for finding bugs.  If you are not
prepared to actually inspect the code the compiler warns about in order to
understand what it is trying to do and in order to judge whether it is doing
that correctly and/or how it should be improved in order to reach correct
results, don't bother looking at compiler warnings.  The crucial part of a fix
for a compiler warning is to make sure that the code is actually doing what it
intends to do.

The main goal of auditing compiler warnings is NOT to silence the warnings. 
Auditing them with that objective in mind is worse than useless.  The outcome
of "fixing" compiler warnings in that mindset usually is hiding existing bugs
AND introducing new bugs.

That said, we still don't know how to fix the actual bug that the compiler
warning revealed.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55044>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/