bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #54114] QUICK TYPO FIX in tbl(1): `tbl(c)' should be `tab(c)'


From: Michael Witten
Subject: [bug #54114] QUICK TYPO FIX in tbl(1): `tbl(c)' should be `tab(c)'
Date: Mon, 18 Jun 2018 09:29:30 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux i686; rv:57.0) Gecko/20100101 Firefox/57.0

Follow-up Comment #6, bug #54114 (project groff):


[rational reply intentionally written in English]

* My report explains "git am".
  ----------------------------

  The first  thing my bug  report states is  how to use  "git am"
  to  apply  the  patch,  with  the  explicit  reason  being  the
  preservation of the authorship information.

  Why do  you think I  even felt compelled  to do this?  It's not
  because I'm super serious about having this typo fix attributed
  to  me, but  rather because  I  had a  gut feeling  that a  GNU
  maintainer would fsck it up again; well, I nailed it.

* I'd never commit  someone else's work under my  name, no matter
  ---------------------------------------------------------------
  how small.
  ----------

  Indeed,  the first  thing  I'd  do as  a  maintainer is  figure
  out  how to  use  my tools  to  preserve authorship  correctly.
  Pretty quickly, I'd  learn at least the  following command line
  arguments for "git commit":
  
    --author
    --date
  
  and probably the following environment variables:

    GIT_AUTHOR_NAME
    GIT_AUTHOR_EMAIL
    GIT_AUTHOR_DATE

  and  certainly,  I'd  be  intrigued by  a  contributor  who  is
  directing me in precisely how to apply a patch ("Is there some-
  thing I don't know about? Let me look into this.").

* Yes, mistakes happen. Apologize for them to preserve good will.
  --------------------------------------------------------------

  One of the most important jobs of a maintainer is to make other
  people want  to do work, virtually  for free; hell, I  even did
  the work of explaining how to  apply a patch properly, so as to
  make the process as convenvient as possible.

  And, you know what?

  Though I'm not suggesting this be done, if I were a maintainer,
  I'd  be more  than  happy to  fix  a mistake  like  this; as  a
  maintainer,  I would  take pride  in  correcting a  bug in  the
  history by inserting an "empty" commit with the correct inform-
  ation (I had to figure out how to do this):

    git checkout master
    git reset --hard HEAD
    git log -1 --format='%H %T' | {
      read head tree
      commit=$(
        {
          echo "Correct commit authorship"
          echo
          echo "The authorship info for this commit is what"
          echo "should be the authorship info for commit"
          echo "'82d56c12d4e131ec072ad3525d7f683c6acd2261'."
        } | GIT_AUTHOR_NAME='Michael Witten'                  \
            GIT_AUTHOR_EMAIL='address@hidden'             \
            GIT_AUTHOR_DATE='Thu, 14 Jun 2018 05:02:42 +0000' \
              git commit-tree -p "$head" "$tree"
      )
      git reset --hard "$commit"
    }

  Of course, I do NOT want that "fix" actually applied (certainly
  not for a  typo), but as a  maintainer, I'd do it,  not only to
  improve my  understanding of maintaining the  history, but also
  to foster good will rather than alienation.

* It is irritating to contribute to GNU projects.
  -----------------------------------------------

  Your projects  have lost  a lot of  brainpower over  the years,
  because people have been finding  it way too irritating to make
  contributions.

  Make it enjoyable to contribute.

Sincerely,
Michael Witten



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54114>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]