[bug #52335] src: Some warnings from the compiler that need fixing or explanations in the code

[G. Branden Robinson]

Follow-up Comment #1, bug #52335 (project groff):

Hi Bjarni,

I believe fall-through is the correct behavior for groff.cpp, line 295.

However, I don't have GCC 7 handy.  Can you test the following patch, please?


diff --git a/src/roff/groff/groff.cpp b/src/roff/groff/groff.cpp
index 46cbf018..ef654f6d 100644
--- a/src/roff/groff/groff.cpp
+++ b/src/roff/groff/groff.cpp
@@ -293,6 +293,7 @@ int main(int argc, char **argv)
       break;
     case 'o':
       oflag = 1;
+      __attribute__ ((fallthrough));
     case 'f':
     case 'm':
     case 'r':


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52335>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/