bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23712: [PATCH 1/6] maint: mark a couple of static variables const


From: Paul Eggert
Subject: bug#23712: [PATCH 1/6] maint: mark a couple of static variables const
Date: Wed, 17 Aug 2016 18:54:05 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

Thanks, this patch was installed into grep in June so I'm marking the bug report as done.

Also, I installed the attached two patches as followup. The first is because I've run into too many compilers that complain about 'static const int x;' on the grounds that x should have an initializer. Rewriting the code to avoid these zero constants makes the code a tiny bit smaller on x86-64, so it's likely a tiny win anyway.

The 2nd patch changes this code to use 64-bit words on x86-64 GNU/Linux, much as other parts of grep already do. This makes the code a tiny bit smaller too.

The runtime performance change is likely so small I haven't bothered to try to measure it. Perhaps some day compilers will be smart enough to put those 256-bit arrays into registers and regex nerds can tune it some more....

Attachment: 0001-dfa-avoid-uninitialized-constants.patch
Description: Text Data

Attachment: 0002-dfa-use-64-bit-when-ulong-is-at-least-that-wide.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]