[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#17472: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror st
From: |
behoffski |
Subject: |
bug#17472: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings |
Date: |
Mon, 12 May 2014 13:31:24 +0930 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
A few months ago, "make syntax-check" would complain if any string that
was subject to localisation started with an upper-case character.
Almost all messages in Grep conform to this standard. However,
"make syntax-check" no longer complains about two cases in the current
master (dfa.c, function lex ()):
dfaerror (_("Invalid content of \\{\\}"));
dfaerror (_("Regular expression too big"));
I don't know if this constraint is being relaxed, or if the check has
changed somehow. (Is syntax-check provided via gnulib?)
Attached is a simple patch that converts the two error strings above to
have a lower-case first character. This may be useful to help maintain
consistent message formatting.
cheers,
behoffski (Brenton Hoff)
Programmer, Grouse Software
01-lowercase-lex-dfaerror-messages.patch
Description: Text Data
- bug#17472: [PATCH] dfa.c (lex): Remove capitalisation of two dfaerror strings,
behoffski <=