[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: exercise two recently-fixed bugs
From: |
Paul Eggert |
Subject: |
Re: [PATCH] tests: exercise two recently-fixed bugs |
Date: |
Sun, 18 Mar 2012 16:09:47 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 |
On 03/18/2012 11:34 AM, Jim Meyering wrote:
> it would be good to add a test
> that requires each of the two new DFA-emitted diagnostics.
Yes, and more generally, the BRE and ERE tests could check for
spelling of diagnostics, and grep could use the same spellings in
both the regex and the dfa cases. This could be done in two
more patches, I suppose. Things could get a little tricky there,
though, as the spellings might differ depending on whether grep
is built --with-included-regex. Possibly dfa.c should not use
its own diagnostic strings at all, and just use regex's. But
this is turning into a bigger project....
Anyway, for now I pushed the fix, with your cfg.mk patch added.
- Re: [PATCH] tests: exercise two recently-fixed bugs, (continued)
- Re: [PATCH] tests: exercise two recently-fixed bugs, Jim Meyering, 2012/03/16
- Re: [PATCH] tests: exercise two recently-fixed bugs, Paolo Bonzini, 2012/03/16
- Re: [PATCH] tests: exercise two recently-fixed bugs, Paolo Bonzini, 2012/03/16
- Re: [PATCH] tests: exercise two recently-fixed bugs, Jim Meyering, 2012/03/16
- Re: [PATCH] tests: exercise two recently-fixed bugs, Paul Eggert, 2012/03/16
- Re: [PATCH] tests: exercise two recently-fixed bugs, Jim Meyering, 2012/03/16
- Re: [PATCH] tests: exercise two recently-fixed bugs, Paul Eggert, 2012/03/16
- Re: [PATCH] tests: exercise two recently-fixed bugs, Jim Meyering, 2012/03/17
- Re: [PATCH] tests: exercise two recently-fixed bugs, Paul Eggert, 2012/03/17
- Re: [PATCH] tests: exercise two recently-fixed bugs, Jim Meyering, 2012/03/18
- Re: [PATCH] tests: exercise two recently-fixed bugs,
Paul Eggert <=
- Re: [PATCH] tests: exercise two recently-fixed bugs, Jim Meyering, 2012/03/18