Re: [PATCH] build: accommodate -Wshadow and -Werror=suggest-attribute=pure

[Paolo Bonzini]

On 02/05/2012 06:01 PM, Jim Meyering wrote:
> Hi Paolo,
>
> Your just-pushed changes provoked these new warnings:
>
>      dfa.c: In function 'state_separate_contexts.isra.1':
>      dfa.c:2131:1: error: function might be candidate for attribute 'pure' if 
> it is kn
>      own to return normally [-Werror=suggest-attribute=pure]
>      cc1: all warnings being treated as errors
>      dfa.c: In function 'dfaexec':
>      dfa.c:3276:14: error: declaration of 'newline' shadows a global 
> declaration [-Werror=shadow]
>      dfa.c:573:18: error: shadowed declaration is here [-Werror=shadow]
>
> Please configure with --enable-gcc-warnings.
> That would have caught at least the shadowing warning.
> For the other, you might have to build on rawhide or with gcc-4.7

Thanks for the heads up.

ACK to the patch, of course.

Paolo