Re: [PATCH 2/3] tests: tiny simplification in TESTS_ENVIRONMENT definition

[Jim Meyering]

Stefano Lattarini wrote:

> Hi Jim, thanks for the quick answer.
>
> On Monday 10 October 2011, Jim Meyering wrote:
>> Stefano Lattarini wrote:
>> > * tests/Makefile.am (TESTS_ENVIRONMENT): Remove redundant use of
>> > `export'.
>> > ---
>> >  tests/Makefile.am |    2 +-
>> >  1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/tests/Makefile.am b/tests/Makefile.am
>> > index 736df9e..13d3ca6 100644
>> > --- a/tests/Makefile.am
>> > +++ b/tests/Makefile.am
>> > @@ -121,7 +121,7 @@ TESTS_ENVIRONMENT =                            \
>> >    CC='$(CC)'                                      \
>> >    GREP_TEST_NAME=`echo $$tst|sed 's,^\./,,;s,/,-,g'` \
>> >    MAKE=$(MAKE)                                    \
>> > -  MALLOC_PERTURB_=$(MALLOC_PERTURB_); export MALLOC_PERTURB_ \
>> > +  MALLOC_PERTURB_=$(MALLOC_PERTURB_)              \
>> >    PACKAGE_BUGREPORT='$(PACKAGE_BUGREPORT)'        \
>> >    PACKAGE_VERSION=$(PACKAGE_VERSION)              \
>> >    PERL='$(PERL)'                          \
>>
>> Thank you.  I'll push all three in a minute.
>>
>> Actually, removing that "; export MALLOC_PERTURB_" could
>> be seen as a bug fix, since that semicolon mistakenly arranged
>> for preceding settings (like CC, MAKE, etc.) *not* to be put into
>> the environment of each test.
>>
> No, there was an `explicit' export early on that ensured all the
> variable definitions were really exported.  This is just a fix for
> a cosmetic issue (but still nice to have IMHO).

Oh, good.  No wonder I didn't notice any problem.  Thanks.